Skip to content

chore: remove storybook directory from chromatic externals#2598

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
cylewaitforit:chromatic-reduce-cache-busting
Apr 20, 2026
Merged

chore: remove storybook directory from chromatic externals#2598
ghostdevv merged 2 commits intonpmx-dev:mainfrom
cylewaitforit:chromatic-reduce-cache-busting

Conversation

@cylewaitforit
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit commented Apr 20, 2026

🔗 Linked issue

🧭 Context

Removes .storybook directory from the chromatic externals to reduce cache busting.

Per @JReinhold

I actually think we should remove the .storybook dir from the cache busting mechanism entirely. I don't think it's necessary honestly, as Chromatic already should be smart enough to find when dependencies in that dir (or the global preview file) is changed.

📚 Description

Let's chromatic determine itself which of the files in .storybook is important to affect snapshots.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Apr 20, 2026 0:36am
npmx.dev Ready Ready Preview, Comment Apr 20, 2026 0:36am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Apr 20, 2026 0:36am

Request Review

@cylewaitforit cylewaitforit marked this pull request as ready for review April 20, 2026 12:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c4762d1c-c00b-4d12-b54a-b4ada7c6de94

📥 Commits

Reviewing files that changed from the base of the PR and between 67b1322 and f48daa3.

📒 Files selected for processing (1)
  • chromatic.config.json
📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build configuration to refine external dependencies handling during the build process.

Walkthrough

The chromatic.config.json file has been updated to modify the externals configuration. The entry ".storybook/**" has been removed from the externals list, leaving only "uno.config.ts" and "uno.theme.ts" as external dependencies.

Changes

Cohort / File(s) Summary
Configuration
chromatic.config.json		 Removed ".storybook/**" from the externals array, retaining only "uno.config.ts" and "uno.theme.ts".
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the storybook directory from chromatic externals configuration.
Description check ✅ Passed The description clearly explains the change, provides context and rationale from a team member, and aligns with the modification shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue Apr 20, 2026
Merged via the queue into npmx-dev:main with commit 6e9a66a Apr 20, 2026
20 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Apr 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghostdevv ghostdevv ghostdevv approved these changes

+1 more reviewer

@JReinhold JReinhold JReinhold approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cylewaitforit @JReinhold @ghostdevv